-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Remove curandStateMTGP32 usage #21301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove curandStateMTGP32 usage gh-metadata: pytorch pytorch 21301 gh/syed-ahmed/13/head
|
Sorry if this is a noob question but is there some way for me to be able to start utilizing these changes before they are fully tested? I am running across this error and hoping this fix will resolve them. |
Remove curandStateMTGP32 usage gh-metadata: pytorch pytorch 21301 gh/syed-ahmed/13/head
|
@ryanchesler The changes should be landing very soon if you could wait a bit. If not, you can find the full diff here: https://github.com/pytorch/pytorch/commits/gh/syed-ahmed/13/orig. It's the first 5 commits. |
Remove curandStateMTGP32 usage gh-metadata: pytorch pytorch 21301 gh/syed-ahmed/13/head
|
@ezyang all tests have passed in the stack. GitHub is just not updating the statuses |
|
Awesome. Glad this is making it through. Hopefully it solves the issue blocking me. |
|
Hey @syed-ahmed this stack is conflicting with cauchy which I just landed. Can you rebase past that? |
Remove curandStateMTGP32 usage gh-metadata: pytorch pytorch 21301 gh/syed-ahmed/13/head
|
Rebased :) |
Summary: Pull Request resolved: pytorch/pytorch#21301 ghimport-source-id: d4516237a8fb46d1f74c47532e849e5926fc6a79 Differential Revision: D15632929 Pulled By: ezyang fbshipit-source-id: b5147edb95dc3d71f87581aa2ab002e48c3fef30
|
Hi, Do you have an idea when this feature will be available in a stable version? I want to publish my code, and make it clear which version of Pytorch I used so it will be easy to install/reproduce. Thanks! |
|
It will probably be included in 1.2 (assuming it doesn't get reverted before branch cut). You can also try using a nightly to get binaries with the fix earlier. |
|
Thanks! I hope 1.2.0 will be released soon! |
|
hi, I searched in the notes (key: rng, 21301), and did not find it. |
|
Yes it's in 1.2.0; 0e3c4a0 is reachable from v1.2.0 branch. It does look like this is missing from the changelog notes. |
|
thanks! |
Stack from ghstack:
Resubmit of #20886
Summary:
This PR removes curandStateMTGP32 usages since it's not stream-safe.
Main changes are:
Differential Revision: D15632929