Add flag to temporarily enable first class modules #21272
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: this flag is used in tests to enable first-class module execution so that we can test things like invoking methods on first-class modules and setting their properties before we implement all the parts necessary to remove the old execution pattern.
This was referenced Jun 3, 2019
Add flag to temporarily enable first class modules Summary: this flag is used in tests to enable first-class module execution so that we can test things like invoking methods on first-class modules and setting their properties before we implement all the parts necessary to remove the old execution pattern. gh-metadata: pytorch pytorch 21272 gh/zdevito/46/head
Add flag to temporarily enable first class modules Summary: this flag is used in tests to enable first-class module execution so that we can test things like invoking methods on first-class modules and setting their properties before we implement all the parts necessary to remove the old execution pattern. gh-metadata: pytorch pytorch 21272 gh/zdevito/46/head
Krovatkin
approved these changes
Jun 5, 2019
| foo = Foo() | ||
| input = torch.rand(3, 4) | ||
| foo.forward(input) | ||
| self.assertEqual(input, foo.foo) |
Contributor
There was a problem hiding this comment.
nitpick: foo.bar might be a little bit more readable
|
|
||
| IValue Method::operator()(std::vector<IValue> stack, const Kwargs& kwargs) { | ||
| getSchema().checkAndNormalizeInputs(stack, kwargs); | ||
| if (experimental_run_as_first_class) { |
Contributor
There was a problem hiding this comment.
nitpick: this logic (pushing module and parameters onto a stack) seems to be duplicated across run and (). Maybe we should consider refactoring it into a helper, otherwise we might forget to update one of the places eventually?
|
|
||
| struct TORCH_API Method { | ||
| Method(Module* owner, Function* function); | ||
| Method(Module* owner, const std::shared_ptr<Function>& function); |
Contributor
There was a problem hiding this comment.
so someone else now owns a function aside from Method?
Contributor
Author
There was a problem hiding this comment.
for now yes, Michael is working on our final state for Function ownership which will make this stuff more clear.
Add flag to temporarily enable first class modules Summary: this flag is used in tests to enable first-class module execution so that we can test things like invoking methods on first-class modules and setting their properties before we implement all the parts necessary to remove the old execution pattern. gh-metadata: pytorch pytorch 21272 gh/zdevito/46/head
This was referenced Jun 7, 2019
Add flag to temporarily enable first class modules Summary: this flag is used in tests to enable first-class module execution so that we can test things like invoking methods on first-class modules and setting their properties before we implement all the parts necessary to remove the old execution pattern. gh-metadata: pytorch pytorch 21272 gh/zdevito/46/head
Add flag to temporarily enable first class modules Summary: this flag is used in tests to enable first-class module execution so that we can test things like invoking methods on first-class modules and setting their properties before we implement all the parts necessary to remove the old execution pattern. gh-metadata: pytorch pytorch 21272 gh/zdevito/46/head
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary: this flag is used in tests to enable first-class module
execution so that we can test things like invoking methods on
first-class modules and setting their properties before we implement
all the parts necessary to remove the old execution pattern.
Differential Revision: D15600068