The error would only have been caught under the pytorch_linux_xenial_cuda9_cudnn7_py2_test configuration, which is not part of the default set. This is the first instance I'm aware of where the reduction of default tests we ran resulted in a failure not being caught.

To be clear, this was not a "syntax" error per se: it was incorrect spelling of super() keyword. For this particular case, a lint rule might be sufficient to catch occurrences of this in the future.

it was incorrect spelling of super() keyword. For this particular case, a lint rule might be sufficient to catch occurrences of this in the future.

@ezyang I would like to make sure I understand the cause of the previous error. I was using super().__init__() in #21197. I thought I run into the error because that is only allowed in py3. To make it work for both py2 and py3, I need to use super(TestModule, self).__init__().

You're correct. All I am clarifying is that there is no syntax error in your Python 3-only code (in the sense that, a SyntaxError would have been raised). Syntax errors are much easier to catch because parsing of the file will fail, even if the code is not exercised.

@mrshenli merged this pull request in f62a006.