Reduce number of stack manipulation instructions in interpreter. #21240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 1, 2019
zdevito
changed the title
…reter." unfinished push/pop reduction gh-metadata: pytorch pytorch 21240 gh/zdevito/45/head
This was referenced Jun 3, 2019
…reter." unfinished push/pop reduction gh-metadata: pytorch pytorch 21240 gh/zdevito/45/head
suo
requested changes
Jun 5, 2019
Member
suo
left a comment
suo
left a comment
There was a problem hiding this comment.
requesting changes to clear my queue, pls re-request when it's ready
…reter." unfinished push/pop reduction gh-metadata: pytorch pytorch 21240 gh/zdevito/45/head
suo
approved these changes
Jun 5, 2019
| // and we can short circuit doing many instructions here | ||
| // by either clearing the register (DROPR) or just popping the stack | ||
| // (DROP) | ||
| if (preprocess_.can_emit_inline[input->node()]) { |
Member
There was a problem hiding this comment.
can you add a comment about what the significant of the check to can_emit_inline is here
…reter." unfinished push/pop reduction gh-metadata: pytorch pytorch 21240 gh/zdevito/45/head
This was referenced Jun 7, 2019
…reter." unfinished push/pop reduction gh-metadata: pytorch pytorch 21240 gh/zdevito/45/head
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the number of stack manipulation instructions by finding places where we can operate directly on the stack.
Stack from ghstack:
For TestScript, this reduces the total number of instructions emitted across the test suite from 50k to 37k.
I also used the following script:
To time the interpreter overhead using the new approach compared to the old approach. Both performed with no measurable performance differences, suggesting the overheads lie not in the interpretation but in other aspects (e.g. refcounting, std::function invocation).