Add gelu gradient for pytorch #21237
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
module: cpu
soumith
approved these changes
Jun 1, 2019
Contributor
soumith
left a comment
soumith
left a comment
There was a problem hiding this comment.
please check inline comment and provide resolution on what's up with the tolerance adjustment. Once you get clarity into that, and verify it's not a bug, do land.
Things reviewed in the diff:
- MKL and non-MKL implementations match in formula
- CUDA and CPU implementation match in formula
Things not reviewed in the diff:
- gradient formula is correct (relying on gradcheck to say it's right)
test/test_nn.py
Outdated
Contributor
There was a problem hiding this comment.
this looks suspicious. gradchecks happen in double precision, so a tolerance of 1e-3 looks really high and a custom eps is usually not needed. Any idea what is going on? Can you check some sample inputs to inspect.
Contributor
Author
There was a problem hiding this comment.
This part just came from testing the numerical stability for gradchecks. Atol has been removed and now it is using default value.
xiaomengy
force-pushed
the
export-D15589816
branch
from
d773d72 to
b333c2c
Compare
xiaomengy
force-pushed
the
export-D15589816
branch
from
b333c2c to
2ef4e48
Compare
xiaomengy
force-pushed
the
export-D15589816
branch
from
2ef4e48 to
c1b1d5d
Compare
xiaomengy
force-pushed
the
export-D15589816
branch
from
c1b1d5d to
d247ea1
Compare
pytorchbot
added
the
module: docs
Summary: Add gelu activation forward on CPU in pytorch Differential Revision: D15400974 fbshipit-source-id: 1c59104bea69cbe26ab96921e242131890db657e
Summary: Pull Request resolved: pytorch#21237 Add gelu gradient for pytorch Reviewed By: zheng-xq Differential Revision: D15589816 fbshipit-source-id: 2feb4ed779cda1dec3fe03fcfba29861b4a86d12
xiaomengy
force-pushed
the
export-D15589816
branch
from
d247ea1 to
aaf94f7
Compare
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jun 2, 2019
Summary: Pull Request resolved: pytorch/pytorch#21237 Add gelu gradient for pytorch Reviewed By: zheng-xq Differential Revision: D15589816 fbshipit-source-id: 76fda7c413afed5b6cc3abe3a26c258d393a53ce
Contributor
|
This pull request has been merged in 31c79b7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add gelu gradient for pytorch
Differential Revision: D15589816