[ONNX] Support gather export with OneHot + Mul #21235
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
spandantiwari
approved these changes
Jun 4, 2019
|
|
||
| @parse_args('v', 'i', 'v', 'v') | ||
| def gather(g, self, dim, index, sparse_grad=False): | ||
| # NOTE: Update this workaround if ONNX has native Gather support. |
There was a problem hiding this comment.
Maybe rephrase to say that current onnx::Gather does not directly support torch.Gather.
|
|
||
|
|
||
| @parse_args('v', 'i', 'v', 'v') | ||
| def gather(g, self, dim, index, sparse_grad=False): |
There was a problem hiding this comment.
This should also support Opset 10 export, correct?
Member
There was a problem hiding this comment.
Yes, I think so. Should be able to fall back to opset 9's symoblics.
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Member
|
@pytorchbot retest this please |
Contributor
|
@houseroad merged this pull request in 63a55d4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could serve as a alternative solution to export
torch.gatherbefore something similar goes into ONNX spec. The exported model is verified to be correct against onnxruntime backend. We weren't able to test against Caffe2 backend because it doesn't seem to support OneHot opset9.