Skip to content

allow passing Python built-in types as dtypes #21215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
umanwizard wants to merge 3 commits into from
Closed

allow passing Python built-in types as dtypes #21215

umanwizard wants to merge 3 commits into from

Conversation

@umanwizard
Copy link
Contributor

@umanwizard umanwizard commented May 31, 2019

Another simple bit of syntax that NumPy supports and we don't.

Support int, float, and bool.

>>> torch.randn((2,3), dtype=float)
tensor([[-0.1752, -0.3240, -0.6148],
        [ 0.1861,  1.6472,  0.1687]], dtype=torch.float64)

A bit confusingly, Python's "float" actually means double, but nothing we can do about that.

@pytorchbot pytorchbot added module: internals Related to internal abstractions in c10 and ATen module: operators module: pybind Related to our Python bindings / interactions with other Python libraries labels May 31, 2019
@umanwizard umanwizard added the module: numpy Related to numpy support, and also numpy compatibility of our operators label May 31, 2019
@ezyang ezyang added facebook and removed facebook labels Jun 5, 2019
gchanan
gchanan approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@gchanan gchanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks fine although I don't think it will work with JIT.

facebook-github-bot
facebook-github-bot reviewed Jun 6, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@umanwizard has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 7, 2019

@umanwizard merged this pull request in 0a3fb45.

@vivekmig vivekmig mentioned this pull request Nov 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@gchanan gchanan gchanan approved these changes

@colesbury colesbury Awaiting requested review from colesbury

@fmassa fmassa Awaiting requested review from fmassa

Assignees

No one assigned

Labels

Merged module: internals Related to internal abstractions in c10 and ATen module: numpy Related to numpy support, and also numpy compatibility of our operators module: pybind Related to our Python bindings / interactions with other Python libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@umanwizard @facebook-github-bot @gchanan @ezyang @pytorchbot @mruberry