Fix Python DataParallel RNN in no_grad mode #21197
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrshenli
added
oncall: distributed
Contributor
Author
|
This is blocking facebookresearch/mmf/issues/76 |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mrshenli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
soumith
approved these changes
Jun 1, 2019
Contributor
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 3, 2019
Summary: Retry #21197 The previous one failed because it uses some Python3 only syntax. ezyang Do we still have multi-GPU py2 tests? I am curious why the CI tests did not catch this error. Pull Request resolved: #21262 Differential Revision: D15598941 Pulled By: mrshenli fbshipit-source-id: 95f416589448c443685d6d236d205b011998a715
|
Is this fix part of 1.2? |
Contributor
|
@BramVanroy yes, this made 1.2. |
|
Could you also modify the replicate part in The same problem still happens when I call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21108
When grad is disabled, Python autograd function outputs are wrapped as detached aliases, which prevents calling
Tensor.set_()on them after recent changes in Tensors and Variables. This will hit a problem when users would like to callrnn.flatten_parameters()in the forward pass, as the function callsset_().The proposed solution is to avoid using an autograd Broadcast if in no_grad mode.
@apsdehal