[jit] avoid multiple writes to files on export #21186
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't write the same file multiple times. This doesn't have any observable effect on model loading, but it makes running unzip manually confusing (since it will try to unzip multiple files with the same name and ask whether to overwrite them).
driazati
reviewed
May 31, 2019
| const ClassTypePtr& class_type = item.key(); | ||
| const std::string filename = | ||
| ImportExportHelpers::qualifierToPath(class_type->qualifier()); | ||
| if (written_files.count(filename)) { |
Contributor
There was a problem hiding this comment.
Why would it be trying to write out the same class_type multiple times in the first place?
Member
Author
There was a problem hiding this comment.
Multiple class types can resolve to the same file.
driazati
approved these changes
May 31, 2019
Contributor
driazati
left a comment
driazati
left a comment
There was a problem hiding this comment.
lgtm, is this check still needed?
pytorch/torch/csrc/jit/import.cpp
Line 246 in 4dbeb87
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Don't write the same file multiple times. This doesn't have any
observable effect on model loading, but it makes running unzip manually
confusing (since it will try to unzip multiple files with the same name
and ask whether to overwrite them).
Differential Revision: D15581527