-
Notifications
You must be signed in to change notification settings - Fork 26.3k
schema_matching.cpp: improve error messages. #21141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schema_matching.cpp: improve error messages. #21141
Conversation
|
Below is how the error messages changed. Example 1: Before: After: Example 2: Before: After: |
suo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. I expect we have some tests that regex on error output, so you'll need to change those
|
Another thing i think we can change: if this was a method invocation, we should only even consider builtins whose first argument matches. That way when you write |
b1de5c6 to
a70e2bf
Compare
a70e2bf to
955a475
Compare
955a475 to
c785c2f
Compare
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ZolotukhinM has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
c785c2f to
510530d
Compare
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ZolotukhinM has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Pull Request resolved: pytorch/pytorch#21141 Differential Revision: D15769066 Pulled By: ZolotukhinM fbshipit-source-id: 5853e0360581c44e42b068add3bf2bc68e671b2b
|
@ZolotukhinM merged this pull request in 9691025. |
|
This PR didn't pass CUDA tests in the CI and is breaking master. I am reverting. |
510530d to
a8c5049
Compare
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ZolotukhinM has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Pull Request resolved: pytorch/pytorch#21141 Differential Revision: D15808354 Pulled By: ZolotukhinM fbshipit-source-id: 16d938fd5acafb445a0c433cabc9a55cab563165
No description provided.