Skip to content

Conversation

@Chillee
Copy link
Collaborator

@Chillee Chillee commented May 30, 2019

Stack from ghstack:

Differential Revision: D15563183

Added factorial

gh-metadata: pytorch pytorch 21129 gh/chillee/7/head
Added factorial

gh-metadata: pytorch pytorch 21129 gh/chillee/7/head
Added factorial

gh-metadata: pytorch pytorch 21129 gh/chillee/7/head
Added factorial

gh-metadata: pytorch pytorch 21129 gh/chillee/7/head
Added factorial

gh-metadata: pytorch pytorch 21129 gh/chillee/7/head
Added factorial

gh-metadata: pytorch pytorch 21129 gh/chillee/7/head
Chillee added 5 commits May 30, 2019 15:37
Added factorial

gh-metadata: pytorch pytorch 21129 gh/chillee/7/head
Added factorial

gh-metadata: pytorch pytorch 21129 gh/chillee/7/head
Added factorial

gh-metadata: pytorch pytorch 21129 gh/chillee/7/head
Added factorial

gh-metadata: pytorch pytorch 21129 gh/chillee/7/head
Added factorial

gh-metadata: pytorch pytorch 21129 gh/chillee/7/head
Chillee added 9 commits May 31, 2019 11:12
Added factorial

gh-metadata: pytorch pytorch 21129 gh/chillee/7/head
Added factorial

gh-metadata: pytorch pytorch 21129 gh/chillee/7/head
Added factorial

gh-metadata: pytorch pytorch 21129 gh/chillee/7/head
Added factorial

gh-metadata: pytorch pytorch 21129 gh/chillee/7/head
Added factorial

gh-metadata: pytorch pytorch 21129 gh/chillee/7/head
Added factorial

gh-metadata: pytorch pytorch 21129 gh/chillee/7/head
Added factorial

gh-metadata: pytorch pytorch 21129 gh/chillee/7/head
Added factorial

gh-metadata: pytorch pytorch 21129 gh/chillee/7/head
Added factorial

gh-metadata: pytorch pytorch 21129 gh/chillee/7/head
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI test failure is legit.

@Chillee
Copy link
Collaborator Author

Chillee commented Jun 4, 2019

Yep! - the ones before are all green though, I believe (just rate limited).

Chillee added 5 commits June 4, 2019 11:53
Added factorial

gh-metadata: pytorch pytorch 21129 gh/chillee/7/head
Added factorial

gh-metadata: pytorch pytorch 21129 gh/chillee/7/head
Added factorial

gh-metadata: pytorch pytorch 21129 gh/chillee/7/head
Added factorial

gh-metadata: pytorch pytorch 21129 gh/chillee/7/head
Added factorial

gh-metadata: pytorch pytorch 21129 gh/chillee/7/head
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zou3519 zou3519 deleted the gh/chillee/7/head branch June 5, 2019 18:53
@facebook-github-bot
Copy link
Contributor

@Chillee merged this pull request in ba2bdf8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants