Add CallMethod, inline eagerly #21116
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This adds CallMethod to complement CallFunction. Now class method calls are first emitted using CallMethod and Inline then removes them. This preserves intent in the IR better and will be how Interfaces (actually dynamically dispatched methods) will appear in the IR Test Plan: test_jit.py
pytorchbot
added
oncall: jit
This was referenced May 30, 2019
Add CallMethod, inline eagerly Summary: This adds CallMethod to complement CallFunction. Now class method calls are first emitted using CallMethod and Inline then removes them. This preserves intent in the IR better and will be how Interfaces (actually dynamically dispatched methods) will appear in the IR Test Plan: test_jit.py gh-metadata: pytorch pytorch 21116 gh/zdevito/42/head
Add CallMethod, inline eagerly Summary: This adds CallMethod to complement CallFunction. Now class method calls are first emitted using CallMethod and Inline then removes them. This preserves intent in the IR better and will be how Interfaces (actually dynamically dispatched methods) will appear in the IR Test Plan: test_jit.py gh-metadata: pytorch pytorch 21116 gh/zdevito/42/head
This was referenced Jun 1, 2019
Add CallMethod, inline eagerly Summary: This adds CallMethod to complement CallFunction. Now class method calls are first emitted using CallMethod and Inline then removes them. This preserves intent in the IR better and will be how Interfaces (actually dynamically dispatched methods) will appear in the IR Test Plan: test_jit.py gh-metadata: pytorch pytorch 21116 gh/zdevito/42/head
suo
approved these changes
Jun 3, 2019
| loc, f, inputsWithSelf, attributes, n_binders); | ||
| auto method = self_->type()->expect<ClassType>()->getMethod(method_name_); | ||
| TORCH_INTERNAL_ASSERT(method); | ||
| method->ensure_defined(); |
Member
There was a problem hiding this comment.
It seems we are frequently calling ensure_defined() before doing something with a method—I think lazy compilation should be an internal detail of Method and callers shouldn't need to know about it. Don't have to change it here though.
Contributor
Author
There was a problem hiding this comment.
I agree with this, but I don't know of a great place to put it yet. It is possible that we can choose which methods on Function should just call it but I haven't figured out if that works.
|
|
||
| TORCH_API const std::vector<Function*>& getAllBuiltinFunctionsFor(Symbol name); | ||
|
|
||
| TORCH_API const std::vector<std::shared_ptr<Function>>& |
Member
There was a problem hiding this comment.
Why did we change these to owning pointers?
Contributor
Author
There was a problem hiding this comment.
Because the FunctionType object captures them as such when an emitCall happens.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary: This adds CallMethod to complement CallFunction. Now class
method calls are first emitted using CallMethod and Inline then removes
them. This preserves intent in the IR better and will be how Interfaces
(actually dynamically dispatched methods) will appear in the IR
Test Plan: test_jit.py
Differential Revision: D15552816