Parallelize eye() on CPU. #21077
Closed
Parallelize eye() on CPU. #21077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmassa
reviewed
May 29, 2019
Member
There was a problem hiding this comment.
are you sure a grain_size of 1 is the best here? I'd expect that for small tensors the overhead of parallelizing it would dominate.
Collaborator
Author
There was a problem hiding this comment.
I changed this to internal::GRAIN_SIZE. Hope it is sufficient.
ifedan
approved these changes
Jun 3, 2019
Collaborator
Author
|
Any chance to get this merged :) |
Contributor
|
@ifedan please merge them |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jun 6, 2019
Summary: Pull Request resolved: pytorch/pytorch#21077 Differential Revision: D15695329 Pulled By: ezyang fbshipit-source-id: 9841777238dac7c08cde2db3cd9401853f633af3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.