[jit] Fix __constants__ for some nn modules #21071
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
oncall: jit
eellison
approved these changes
May 29, 2019
|
|
||
|
|
||
| class _InstanceNorm(_BatchNorm): | ||
| __constants__ = ['running_mean', 'running_var', 'weight', 'bias', |
Contributor
There was a problem hiding this comment.
why were these all removed ?
Contributor
Author
There was a problem hiding this comment.
They're on the parent class
|
|
||
| @weak_module | ||
| class _ConvTransposeMixin(object): | ||
| __constants__ = ['stride', 'padding', 'kernel_size', 'dim_size', |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of modules were missing entries for
__constants__which was making their__repr__s not work. Others had__constants__that were not necessary since it was provided by some parent class instead.Fixes #20978
Differential Revision: D15539518