better error msg when seeing a unsupported builtin function #21068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdevito
reviewed
Jun 5, 2019
torch/csrc/jit/script/compiler.cpp
Outdated
| } else { | ||
| auto inputs = getNamedValues(apply.inputs(), true); | ||
| auto attributes = emitAttributes(apply.attributes()); | ||
| if (sv->kind() == "python value of type \'builtin_function_or_method\'") { |
Contributor
There was a problem hiding this comment.
This error message probably should go in PythonValue::call not here. kind() is for error message reporting only and shouldn't be used to decide behavior.
added 3 commits
June 6, 2019 14:21
…er_errmsg_for_unsupported_builtin
…er_errmsg_for_unsupported_builtin
pytorchbot
added
the
module: pybind
Contributor
Author
|
@zdevito I updated the PR as suggested, would you mind taking another look when you have time? Thanks! |
zdevito
approved these changes
Jun 11, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ailzhang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/pytorch/lockdown/issues/39.
Hopefully it doesn't break other tests....