Removed accidental TensorFlow dependency #21066
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'm happy to land this as-is, since it is strictly better, but please add a test for add_mesh to https://github.com/pytorch/pytorch/blob/master/test/test_tensorboard.py. That way unit tests should error out if we introduce a TF dependency. Let's do that with a separate PR. |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@orionr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
akyrola
pushed a commit
to akyrola/pytorch
that referenced
this pull request
Jun 3, 2019
Summary: I accidentally added a TF dependency in pytorch#20413 by using the from tensorboard.plugins.mesh.summary import _get_json_config import. I'm removing it at the cost of code duplication. orionr, Please review. Pull Request resolved: pytorch#21066 Reviewed By: natalialunova Differential Revision: D15538746 Pulled By: orionr fbshipit-source-id: 8a822719a4a9f5d67f1badb474e3a73cefce507f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally added a TF dependency in #20413 by using the from tensorboard.plugins.mesh.summary import _get_json_config import.
I'm removing it at the cost of code duplication.
@orionr, Please review.