[jit] bake constants into the traced graph, get rid of getNestedValueTrace #21046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 28, 2019
…NestedValueTrace" [jit] bake constants into the traced graph, get rid of getNestedValueTrace gh-metadata: pytorch pytorch 21046 gh/wanchaol/13/head
…rid of getNestedValueTrace" [jit] bake constants into the traced graph, get rid of getNestedValueTrace gh-metadata: pytorch pytorch 21046 gh/wanchaol/13/head
Contributor
|
Why does is this stacked with the other PRs? |
Collaborator
Author
@eellison it has no relation with the bottom PRs, it's just that I was lazy at creating a new branch for it lol... I can move it to a separate branch if you prefer :) |
zdevito
reviewed
May 29, 2019
Contributor
zdevito
left a comment
zdevito
left a comment
There was a problem hiding this comment.
Looks good, but needs to have error handling and a test for the error handline.
…NestedValueTrace" [jit] bake constants into the traced graph, get rid of getNestedValueTrace gh-metadata: pytorch pytorch 21046 gh/wanchaol/13/head
zdevito
reviewed
Jun 3, 2019
…id of getNestedValueTrace" [jit] bake constants into the traced graph, get rid of getNestedValueTrace gh-metadata: pytorch pytorch 21046 gh/wanchaol/13/head
…NestedValueTrace" [jit] bake constants into the traced graph, get rid of getNestedValueTrace gh-metadata: pytorch pytorch 21046 gh/wanchaol/13/head
zdevito
approved these changes
Jun 4, 2019
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
When tracing a script function, we will stop the tracing state and try to inline the scripted graph, but if the scripted function contains non tensor types, we will fail to trace them as they are not generated by any previous ops or any constants.
This PR helps generate the constants when the tracing call try to inline the script function.
This should fix #21009
Differential Revision: D15530991