Skip to content

Conversation

@Chillee
Copy link
Collaborator

@Chillee Chillee commented May 28, 2019

Not much to say. Fixes implementation introduced here: #19115

@pytorchbot pytorchbot added the oncall: jit Add this issue/PR to JIT oncall triage queue label May 28, 2019
@Chillee Chillee requested review from eellison, jamesr66a, suo and zdevito May 28, 2019 21:24
Copy link
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For future diffs we can maybe define all of the edge case ints in a list and reuse it (max int, min int, 0, etc). (don't need to do it in this PR tho)

@Chillee Chillee changed the title Fixed gcd to use 64 bit integers [jit] Fixed gcd to use 64 bit integers May 28, 2019
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chillee is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Chillee merged this pull request in 2ba608b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants