Enable all and any for bool tensors #21033
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 28, 2019
colesbury
reviewed
May 28, 2019
Member
colesbury
left a comment
colesbury
left a comment
There was a problem hiding this comment.
This needs a test for non-empty any/all
Enable all and any for bool tensors gh-metadata: pytorch pytorch 21033 gh/izdeby/4/head
izdeby
changed the title
Enable all and any for bool tensors gh-metadata: pytorch pytorch 21033 gh/izdeby/4/head
Enable all and any for bool tensors gh-metadata: pytorch pytorch 21033 gh/izdeby/4/head
izdeby
changed the title
Enable all and any for bool tensors gh-metadata: pytorch pytorch 21033 gh/izdeby/4/head
Enable all and any for bool tensors gh-metadata: pytorch pytorch 21033 gh/izdeby/4/head
ezyang
reviewed
May 29, 2019
|
|
||
| Tensor result = at::empty({0}, self.options()); | ||
| auto iter = make_reduction( | ||
| "all", result, self, {}, false, at::ScalarType::Byte); |
Member
There was a problem hiding this comment.
This is fine for now, but the explicit return type was intentional. numpy.all and numpy.any always return a bool array even for non-bool inputs.
ezyang
approved these changes
May 29, 2019
Contributor
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
Approved with comments; I agree with Sam, non-empty case needs testing (or better yet, find where we are testing all/any previously and generalize that test code.)
VitalyFedyunin
approved these changes
May 29, 2019
Enable all and any for bool tensors gh-metadata: pytorch pytorch 21033 gh/izdeby/4/head
Enable all and any for bool tensors gh-metadata: pytorch pytorch 21033 gh/izdeby/4/head
Enable all and any for bool tensors gh-metadata: pytorch pytorch 21033 gh/izdeby/4/head
Enable all and any for bool tensors gh-metadata: pytorch pytorch 21033 gh/izdeby/4/head
Enable all and any for bool tensors gh-metadata: pytorch pytorch 21033 gh/izdeby/4/head
This was referenced May 29, 2019
Enable all and any for bool tensors gh-metadata: pytorch pytorch 21033 gh/izdeby/4/head
Contributor
Author
|
@pytorchbot retest this please |
Enable all and any for bool tensors gh-metadata: pytorch pytorch 21033 gh/izdeby/4/head
Enable all and any for bool tensors gh-metadata: pytorch pytorch 21033 gh/izdeby/4/head
Enable all and any for bool tensors gh-metadata: pytorch pytorch 21033 gh/izdeby/4/head
Enable all and any for bool tensors gh-metadata: pytorch pytorch 21033 gh/izdeby/4/head
Enable all and any for bool tensors gh-metadata: pytorch pytorch 21033 gh/izdeby/4/head
Enable all and any for bool tensors gh-metadata: pytorch pytorch 21033 gh/izdeby/4/head
Enable all and any for bool tensors gh-metadata: pytorch pytorch 21033 gh/izdeby/4/head
Enable all and any for bool tensors gh-metadata: pytorch pytorch 21033 gh/izdeby/4/head
Enable all and any for bool tensors gh-metadata: pytorch pytorch 21033 gh/izdeby/4/head
Enable all and any for bool tensors gh-metadata: pytorch pytorch 21033 gh/izdeby/4/head
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
May 31, 2019
Summary: Pull Request resolved: pytorch/pytorch#21033 ghimport-source-id: 35fdcf27b0bde8ec3e5b3051cf0d730f20f94783 Differential Revision: D15530497 Pulled By: izdeby fbshipit-source-id: 9c15cc960055f59a05ce0276f9d51c567626d966
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This PR is a part of a stack which will change result tensor type of comparison ops from uint8 to bool. As this change is rather big and a lot of prep work is needed, im breaking it into a stack.
Changes in this PR:
Differential Revision: D15530497