Enabled min, max, minall, maxall, cmin, cmax, cmaxValue, cminValue for bool tensors #21031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
module: cpu
This was referenced May 28, 2019
izdeby
requested review from
VitalyFedyunin,
colesbury,
ezyang and
gchanan
and removed request for
ezyang
…minValue for bool tensors" Enabled min, max, minall, maxall, cmin, cmax, cmaxValue, cminValue for bool tensors gh-metadata: pytorch pytorch 21031 gh/izdeby/2/head
ezyang
approved these changes
May 28, 2019
Contributor
|
Adding on to the documentation question from the previous PR; in general, if I want to find out what the semantics of boolean tensors are in the documentation, how can I find this out? If I look at any given function (like max) and I want to know how it behaves on a boolean tensor, how do I know or not? |
…minValue for bool tensors" Enabled min, max, minall, maxall, cmin, cmax, cmaxValue, cminValue for bool tensors gh-metadata: pytorch pytorch 21031 gh/izdeby/2/head
…minValue for bool tensors" Enabled min, max, minall, maxall, cmin, cmax, cmaxValue, cminValue for bool tensors gh-metadata: pytorch pytorch 21031 gh/izdeby/2/head
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
May 29, 2019
…r bool tensors (#21031) Summary: Pull Request resolved: pytorch/pytorch#21031 ghimport-source-id: 379b3e9d20872eb5ad14403ed6751cdb0e730bc5 Reviewed By: ezyang Differential Revision: D15530499 Pulled By: izdeby fbshipit-source-id: f113d6974ee18ac3dfb5c0bcff66865345d137d2
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This PR is a part of a stack which will change result tensor type of comparison ops from uint8 to bool. As this change is rather big and a lot of prep work is needed, im breaking it into a stack.
Changes in this PR:
#if !defined(TH_REAL_IS_BOOL)macro.Differential Revision: D15530499