fix the bug for mkldnn clone #20943
Closed
fix the bug for mkldnn clone #20943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
module: mkldnn
mrshenli
reviewed
May 25, 2019
Contributor
mrshenli
left a comment
mrshenli
left a comment
There was a problem hiding this comment.
@XiaobingSuper Thanks! Shall add your repro code in #20895 as a test for the mkldnn clone?
Collaborator
Author
@mrshenli , added test case, thanks! |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mrshenli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
mrshenli
approved these changes
May 27, 2019
Contributor
mrshenli
left a comment
mrshenli
left a comment
There was a problem hiding this comment.
Thanks for contributing!
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
May 27, 2019
Summary: This PR is to solve the bug for clone a MKLDNN tensor, please see the issue pytorch/pytorch#20895. Pull Request resolved: pytorch/pytorch#20943 Differential Revision: D15511516 Pulled By: mrshenli fbshipit-source-id: 05b41d6c7eaf8703521f4c768b8f26ec8501dc5e
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to solve the bug for clone a MKLDNN tensor, please see the issue #20895.