add support for steps(strides) in tensor slices #20929
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
oncall: jit
suo
approved these changes
Jun 3, 2019
|
|
||
| auto has_step = slice.step().present(); | ||
| // TODO: add support for slicing tuples | ||
| if (has_step) |
torch/csrc/jit/script/compiler.cpp
Outdated
| // TODO: add support for slicing tuples | ||
| if (has_step) | ||
| { | ||
| throw ErrorReport(loc) << "Unsupported operation: slicing tuples isn't supported"; |
Member
There was a problem hiding this comment.
I think this error message is not accurate, right? We do support tuple slices, just not steps
torch/csrc/jit/script/compiler.cpp
Outdated
| } | ||
| } | ||
|
|
||
| auto stride = emitExpr(Expr(slice.stepOr(1))); |
Member
There was a problem hiding this comment.
nit: "stride" is a heavyweight term in pytorch, let's avoid it and stick with step
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@Krovatkin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@Krovatkin merged this pull request in 5b4a188. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.