conditionally defined var better error message #20911
Conversation
|
|
||
| // var is only defined in one branch save error in case it's used later | ||
| auto err = [&](const std::string& v, const std::string& branch) { | ||
| ErrorReport error(stmt); |
There was a problem hiding this comment.
this will get thrown when we try to do getVar to unify value types?
There was a problem hiding this comment.
No, this uses the same mechanism we use when we cannot unify the type of two values. We don't emit an error now, and cache the error msg if they try to use the var again later.
pytorch/torch/csrc/jit/script/compiler.cpp
Line 429 in 4d676d5
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@pytorchbot rebase this please |
|
@pytorchbot retest this please |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@eellison is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
5 participants
i will do loops in a follow up after some other changes I am working on have landed