Skip to content

add batch of string ops #20826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eellison wants to merge 4 commits into from
Closed

add batch of string ops #20826

eellison wants to merge 4 commits into from

Conversation

@eellison
Copy link
Contributor

@eellison eellison commented May 22, 2019 •
edited
Loading

First batch of #20769, handles isupper, islower, isdigit, isspace, isalnum, isalpha, upper, lower

@pytorchbot pytorchbot added the oncall: jit Add this issue/PR to JIT oncall triage queue label May 22, 2019
@eellison eellison requested review from driazati and suo May 22, 2019 21:07
driazati
driazati reviewed May 22, 2019
View reviewed changes
test/test_jit.py
# type: (str) -> Tuple[str, str]
return s.upper(), s.lower()

inputs = ["", "12a", "!B", "12", "a", "B", "aB", "$12", "B12", "AB ",
Copy link
Contributor

@driazati driazati May 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a >1 char string of lowers: "aaaa" or something

facebook-github-bot
facebook-github-bot reviewed May 22, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@eellison
Copy link
Contributor Author

eellison commented May 23, 2019

test failures unrelated

@ezyang
Copy link
Contributor

ezyang commented May 23, 2019

This broke Windows.

00:57:52          C:\Jenkins\workspace\caffe2-builds\py2-cuda9.0-cudnn7-windows-build\torch\csrc\jit\register_prim_ops.cpp(1939): error C2039: 'isalpha': is not a member of 'std' [C:\Jenkins\workspace\caffe2-builds\py2-cuda9.0-cudnn7-windows-build\caffe2\caffe2.vcxproj]
00:57:52          C:\Jenkins\workspace\caffe2-builds\py2-cuda9.0-cudnn7-windows-build\torch\csrc\jit\register_prim_ops.cpp(1940): error C2039: 'isalpha': is not a member of 'std' [C:\Jenkins\workspace\caffe2-builds\py2-cuda9.0-cudnn7-windows-build\caffe2\caffe2.vcxproj]
00:57:52          C:\Jenkins\workspace\caffe2-builds\py2-cuda9.0-cudnn7-windows-build\torch\csrc\jit\register_prim_ops.cpp(1940): error C2039: 'isupper': is not a member of 'std' [C:\Jenkins\workspace\caffe2-builds\py2-cuda9.0-cudnn7-windows-build\caffe2\caffe2.vcxproj]

@eellison
Copy link
Contributor Author

eellison commented May 23, 2019 •
edited
Loading

yep fix out here #20842

@eellison eellison reopened this May 23, 2019
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 23, 2019

@eellison merged this pull request in aebcd80.

facebook-github-bot
facebook-github-bot reviewed May 23, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eellison is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@suo suo Awaiting requested review from suo

+1 more reviewer

@driazati driazati driazati approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@eellison @ezyang @facebook-github-bot @driazati @pytorchbot @mruberry