[jit] fix pow bug on overloads and clean up #20824
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[jit] fix pow bug on overloads and clean up gh-metadata: pytorch pytorch 20824 gh/wanchaol/9/head
cpuhrsch
reviewed
May 22, 2019
| return 0; | ||
| }), | ||
|
|
||
| Operator( |
Contributor
There was a problem hiding this comment.
Why do you get to remove this?
Collaborator
Author
There was a problem hiding this comment.
DEFINE_BINARY_OPS already emit the int/float mixed ops (called DEFINE_INT_FLOAT_OP here), this is not necessary anymore. This was due to some merge conflicts that we did not aware of before..
zdevito
approved these changes
May 22, 2019
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D15458009