Skip to content

Conversation

@bddppq
Copy link
Contributor

@bddppq bddppq commented May 22, 2019

Stack:
    :white_circle:  #20820 Add mkldnn sigmoid operator  💚
    :black_circle:  #20800 Enable torch.jit.trace for mkldnn modules  💚
    :white_circle:  #20799 Add support for save and load mkldnn modules  💛

Pull Request resolved: #20800

Differential Revision: D15447892

Differential Revision: D15447892
Differential Version: 82663775
@pytorchbot pytorchbot added oncall: jit Add this issue/PR to JIT oncall triage queue module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration module: pybind Related to our Python bindings / interactions with other Python libraries labels May 22, 2019
@bddppq bddppq requested review from wanchaol and zdevito May 22, 2019 06:09
Copy link
Collaborator

@wanchaol wanchaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, let's leave a comment in the code for future reference.

Differential Revision: D15447892
Differential Version: 82751523
Differential Revision: D15447892
Differential Version: 82769277
bddppq added 6 commits May 22, 2019 18:29
Differential Revision: D15447892
Differential Version: 82814491
Differential Revision: D15447892
Differential Version: 82826424
Differential Revision: D15447892
Differential Version: 82829032
Differential Revision: D15447892
Differential Version: 82842083
Differential Revision: D15447892
Differential Version: 82845517
Differential Revision: D15447892
Differential Version: 82882390
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 8dedb04.

@bddppq bddppq deleted the export-D15447892 branch May 24, 2019 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged module: mkldnn Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration module: pybind Related to our Python bindings / interactions with other Python libraries oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants