-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Enable torch.jit.trace for mkldnn modules #20800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D15447892 Differential Version: 82663775
dzhulgakov
reviewed
May 22, 2019
wanchaol
approved these changes
May 22, 2019
Collaborator
wanchaol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, let's leave a comment in the code for future reference.
Differential Revision: D15447892 Differential Version: 82751523
Differential Revision: D15447892 Differential Version: 82769277
zdevito
approved these changes
May 22, 2019
Differential Revision: D15447892 Differential Version: 82814491
Differential Revision: D15447892 Differential Version: 82826424
Differential Revision: D15447892 Differential Version: 82829032
Differential Revision: D15447892 Differential Version: 82842083
Differential Revision: D15447892 Differential Version: 82845517
Differential Revision: D15447892 Differential Version: 82882390
Contributor
|
This pull request has been merged in 8dedb04. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Merged
module: mkldnn
Related to Intel IDEEP or oneDNN (a.k.a. mkldnn) integration
module: pybind
Related to our Python bindings / interactions with other Python libraries
oncall: jit
Add this issue/PR to JIT oncall triage queue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:white_circle: #20820 Add mkldnn sigmoid operator 💚
:black_circle: #20800 Enable torch.jit.trace for mkldnn modules 💚
:white_circle: #20799 Add support for save and load mkldnn modules 💛
Pull Request resolved: #20800
Differential Revision: D15447892