[JIT] add str comparisons #20761
Closed
[JIT] add str comparisons #20761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driazati
approved these changes
May 21, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
suo
reviewed
May 21, 2019
| # type: (str, str) -> Tuple[bool, bool, bool, bool, bool, bool] | ||
| return a != b, a == b, a < b, a > b, a <= b, a >= b | ||
|
|
||
| self.checkScript(test, ("1", "2")) |
Member
There was a problem hiding this comment.
will this match python's string comparison semantics? Can we try some more complicated comparisons just to make sure it's consistent
Contributor
Author
There was a problem hiding this comment.
lexicographic ordering is the same between c++ & python
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add string comparisons