Add a new method SummaryWriter.flush() #20607
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Add a new method SummaryWriter.flush() that iterates through all of the FileWriters and flushes them Differential Revision: D15380124 fbshipit-source-id: ac6fbaee0d6d8534f76f0397e69d859ee87396c0
orionr
approved these changes
May 16, 2019
Contributor
orionr
left a comment
orionr
left a comment
There was a problem hiding this comment.
Looks good! Test failures are unrelated.
Contributor
|
This pull request has been merged in c0a2a3b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add a new method SummaryWriter.flush() that iterates through all of the FileWriters and flushes them
Differential Revision: D15380124