Add aten mkldnn backward ops: relu, linear and reshape #20570
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
module: autograd
This was referenced May 16, 2019
li-roy
added
the
triaged
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 13, 2019
Summary: ### mkldnn backward ops list: - [ ] \(#20567) Add aten mkldnn conv2d backward operator 💛 - [ ] \(#20570) Add aten mkldnn backward ops: relu, linear and reshape 💛 - [ ] \(#20571) Add aten mkldnn backward ops: max_pool2d, avg_pool2d and adaptive_avg_poo2d 💛 - [ ] \(#20572) Add aten mkldnn batchnorm backward operator 💛 - [ ] \(#20573) Add aten mkldnn zero_ operator:yellow_heart: - [ ] \(#20575) Add mkldnn mul operator 💛 Pull Request resolved: #20575 Differential Revision: D15799529 Pulled By: bddppq fbshipit-source-id: 4887d8ef1a0e316ad9db199b657d9481fc13e486
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jun 13, 2019
Summary: ### mkldnn backward ops list: - [ ] \(pytorch/pytorch#20567) Add aten mkldnn conv2d backward operator 💛 - [ ] \(pytorch/pytorch#20570) Add aten mkldnn backward ops: relu, linear and reshape 💛 - [ ] \(pytorch/pytorch#20571) Add aten mkldnn backward ops: max_pool2d, avg_pool2d and adaptive_avg_poo2d 💛 - [ ] \(pytorch/pytorch#20572) Add aten mkldnn batchnorm backward operator 💛 - [ ] \(pytorch/pytorch#20573) Add aten mkldnn zero_ operator:yellow_heart: - [ ] \(pytorch/pytorch#20575) Add mkldnn mul operator 💛 Pull Request resolved: pytorch/pytorch#20575 Differential Revision: D15799529 Pulled By: bddppq fbshipit-source-id: 4887d8ef1a0e316ad9db199b657d9481fc13e486
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 14, 2019
Summary: ### mkldnn backward ops list: - [ ] \(#20567) Add aten mkldnn conv2d backward operator 💛 - [ ] \(#20570) Add aten mkldnn backward ops: relu, linear and reshape 💛 - [ ] \(#20571) Add aten mkldnn backward ops: max_pool2d, avg_pool2d and adaptive_avg_poo2d 💛 - [ ] \(#20572) Add aten mkldnn batchnorm backward operator 💛 - [ ] \(#20573) Add aten mkldnn zero_ operator:yellow_heart: - [ ] \(#20575) Add mkldnn mul operator 💚 Pull Request resolved: #20573 Differential Revision: D15820477 Pulled By: bddppq fbshipit-source-id: 35d95f5b4e013c8db1911f52148550a2e40a2e68
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jun 14, 2019
Summary: ### mkldnn backward ops list: - [ ] \(pytorch/pytorch#20567) Add aten mkldnn conv2d backward operator 💛 - [ ] \(pytorch/pytorch#20570) Add aten mkldnn backward ops: relu, linear and reshape 💛 - [ ] \(pytorch/pytorch#20571) Add aten mkldnn backward ops: max_pool2d, avg_pool2d and adaptive_avg_poo2d 💛 - [ ] \(pytorch/pytorch#20572) Add aten mkldnn batchnorm backward operator 💛 - [ ] \(pytorch/pytorch#20573) Add aten mkldnn zero_ operator:yellow_heart: - [ ] \(pytorch/pytorch#20575) Add mkldnn mul operator 💚 Pull Request resolved: pytorch/pytorch#20573 Differential Revision: D15820477 Pulled By: bddppq fbshipit-source-id: 35d95f5b4e013c8db1911f52148550a2e40a2e68
dzhulgakov
reviewed
Jul 15, 2019
tools/autograd/derivatives.yaml
Outdated
| # NB: `output` instead of `self` saves memory. It avoids saving a copy of self. | ||
| - name: relu_(Tensor self) | ||
| self: threshold_backward(grad, result, 0) | ||
| self: relu_backward(grad, result) |
Collaborator
There was a problem hiding this comment.
I wonder whether it'd have been easier to just implement threshold_backward directly for mkldnn and error out if threshold is non zero. That way you'd need to change less of existing code.
tools/autograd/derivatives.yaml
Outdated
| - name: mkldnn_linear(Tensor input, Tensor weight, Tensor bias) | ||
| input, weight, bias: mkldnn_linear_backward(input, grad, weight, grad_input_mask) | ||
|
|
||
| - name: mkldnn_reshape(Tensor self, IntArrayRef shape) |
Collaborator
There was a problem hiding this comment.
I'm surprised it does what you want, the method name in native_functions.yaml starts with underscore: _mkldnn_reshape
XiaobingSuper
force-pushed
the
mkldnn_relu_linear
branch
from
57b973e to
1c28533
Compare
Collaborator
Author
XiaobingSuper
force-pushed
the
mkldnn_relu_linear
branch
from
1c28533 to
b605f27
Compare
XiaobingSuper
force-pushed
the
mkldnn_relu_linear
branch
from
b605f27 to
f6d7328
Compare
XiaobingSuper
force-pushed
the
mkldnn_relu_linear
branch
from
f6d7328 to
edacfaf
Compare
Collaborator
Author
XiaobingSuper
force-pushed
the
mkldnn_relu_linear
branch
from
edacfaf to
0784b5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mkldnn backward ops list: