[ONNX] Add ONNX export support for torch.rand. #20559
Conversation
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
houseroad
left a comment
houseroad
left a comment
There was a problem hiding this comment.
Looks good, thanks!
Nit: adding an end to end test like torch.randn_like:
https://github.com/pytorch/pytorch/blob/master/test/onnx/test_pytorch_onnx_caffe2.py#L1341
pytorchbot
added
caffe2
module: pybind
|
@houseroad - thanks for the review. I have added support for |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
rebase to master to let the CI pass? |
spandantiwari
force-pushed
the
spandantiwari/add_onnx_rand
branch
from
4db2d87 to
ed3ccfe
Compare
Rebased. |
|
@spandantiwari could you rebase again? the CI was broken again... really sorry about that. |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
spandantiwari
force-pushed
the
spandantiwari/add_onnx_rand
branch
from
ed3ccfe to
8c7dedd
Compare
No worries. Done. |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@houseroad merged this pull request in 22865d4. |
6 participants
This PR adds support for torch.rand export in the PyTorch ONNX exporter. There are other generator ops that need to be supported for export and they will added in subsequent PRs. This op is needed with priority for a model on our end.