Skip to content

ONNX Export Slice and Flip ops for opset 10 #20533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lara-hdr wants to merge 11 commits into from
Closed

ONNX Export Slice and Flip ops for opset 10 #20533

lara-hdr wants to merge 11 commits into from

Conversation

@lara-hdr
Copy link
Contributor

@lara-hdr lara-hdr commented May 15, 2019

No description provided.

@pytorchbot pytorchbot added the module: onnx Related to torch.onnx label May 15, 2019
@lara-hdr lara-hdr changed the title ONNX Export Slice op for opset 10 ONNX Export Slice and Flip op for opset 10 May 15, 2019
@lara-hdr lara-hdr changed the title ONNX Export Slice and Flip op for opset 10 ONNX Export Slice and Flip ops for opset 10 May 15, 2019
@li-roy li-roy added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 16, 2019
@li-roy li-roy requested a review from houseroad May 16, 2019 23:53
houseroad
houseroad reviewed May 20, 2019
View reviewed changes
houseroad
houseroad reviewed May 20, 2019
View reviewed changes
houseroad
houseroad reviewed May 20, 2019
View reviewed changes
houseroad
houseroad reviewed May 20, 2019
View reviewed changes
houseroad
houseroad reviewed May 20, 2019
View reviewed changes
houseroad
houseroad reviewed May 20, 2019
View reviewed changes
houseroad
houseroad requested changes May 20, 2019
View reviewed changes
Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the inline comments.

houseroad
houseroad reviewed May 30, 2019
View reviewed changes
facebook-github-bot
facebook-github-bot reviewed May 31, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@lara-hdr
Copy link
Contributor Author

lara-hdr commented Jun 3, 2019

@houseroad any updates on this?

facebook-github-bot
facebook-github-bot reviewed Jun 3, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@lara-hdr lara-hdr mentioned this pull request Jun 5, 2019
Closed
@houseroad
Copy link
Member

houseroad commented Jun 6, 2019

@pytorchbot retest this please

facebook-github-bot
facebook-github-bot reviewed Jun 6, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@lara-hdr
Copy link
Contributor Author

lara-hdr commented Jun 7, 2019

@pytorchbot rebase this please

houseroad
houseroad reviewed Jun 7, 2019
View reviewed changes
torch/onnx/symbolic_opset10.py
avg_pool3d = _avg_pool('avg_pool3d', _triple)


def slice_op(g, input, axes, starts, ends, steps=None, dynamic_slice=False):
Copy link
Member

@houseroad houseroad Jun 7, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, is this still necessary? oh you call it in the _slice_op...

facebook-github-bot
facebook-github-bot reviewed Jun 7, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

houseroad
houseroad approved these changes Jun 7, 2019
View reviewed changes
Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@lara-hdr
Copy link
Contributor Author

lara-hdr commented Jun 7, 2019

Thank you @houseroad!!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 7, 2019

@houseroad merged this pull request in cc85c3d.

@garymm garymm mentioned this pull request Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@houseroad houseroad houseroad approved these changes

Assignees

No one assigned

Labels

Merged module: onnx Related to torch.onnx open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@lara-hdr @houseroad @facebook-github-bot @ezyang @li-roy @pytorchbot @mruberry