-
Notifications
You must be signed in to change notification settings - Fork 26.3k
[tensorboard] Support 3D mesh/point cloud #20413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summaries containing data added, needs to `merge` them into one.
|
Hi, which version of tensorboard are you using? |
|
The nightly version from pip: |
orionr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excellent! Really exciting and great to see this contribution. We need to add a bit more documentation and cinch up the code a bit, but this is great. @lanpa you might be better equipped to get this in a ready state, but I added some comments here for all of us.
|
Oh, I wasn't supposed to merge master just yet, how can I fix this? |
orionr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
@pytorchbot retest this please. |
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orionr is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Unrelated test failures. |
Summary: I accidentally added a TF dependency in #20413 by using the from tensorboard.plugins.mesh.summary import _get_json_config import. I'm removing it at the cost of code duplication. orionr, Please review. Pull Request resolved: #21066 Reviewed By: natalialunova Differential Revision: D15538746 Pulled By: orionr fbshipit-source-id: 8a822719a4a9f5d67f1badb474e3a73cefce507f
Summary: I accidentally added a TF dependency in pytorch#20413 by using the from tensorboard.plugins.mesh.summary import _get_json_config import. I'm removing it at the cost of code duplication. orionr, Please review. Pull Request resolved: pytorch#21066 Reviewed By: natalialunova Differential Revision: D15538746 Pulled By: orionr fbshipit-source-id: 8a822719a4a9f5d67f1badb474e3a73cefce507f
I started adding support for the new mesh/point cloud data type introduced to TensorBoard recently.
I created the functions to add the data, created the appropriate summaries.
This new data type however requires a Merged summary containing the data for the vertices, colors and faces.
I got stuck at this stage. Maybe someone can help. @lanpa?
I converted the example code by Google to PyTorch:
I tried adding only the vertex summary, hence the others are supposed to be optional.
I got the following error from TensorBoard and it also didn't display the points: