Skip to content

Conversation

@killeent
Copy link
Contributor

Addresses #1953. I think the best solution is to only test duplicate elements for gets as the NumPy documentation does not make any guarantees about the ordering:

(from https://docs.scipy.org/doc/numpy/reference/arrays.indexing.html)

For advanced assignments, there is in general no guarantee for the iteration order. This means that if an element is set more than once, it is not possible to predict the final result.

@soumith soumith merged commit 10a8ccf into pytorch:master Jul 10, 2017
houseroad added a commit to houseroad/pytorch that referenced this pull request May 30, 2019
…8eb2ca (pytorch#21057)

Summary:
Pull Request resolved: pytorch#21057

Previous import was cc2333a3f929caca7223b98699237f19388dd585

Included changes:
- **[90052912](onnx/onnx@90052912)**: Fix wrong condition and add --user in update_doc.sh (pytorch#2050) <daquexian>
- **[a4f44a20](onnx/onnx@a4f44a20)**: Add bit-shift operators for supporting hashing (pytorch#1931) <Wei-Sheng Chin>
- **[0098752c](onnx/onnx@0098752c)**: Add shape inference logic for Expand op (pytorch#2041) <Hariharan Seshadri>
- **[fbe8addb](onnx/onnx@fbe8addb)**: update qops tests (pytorch#2040) <Ashwini Khade>
- **[874fb37c](onnx/onnx@874fb37c)**: Fix torchvision installation (pytorch#2054) <bddppq>
- **[1f5f6582](onnx/onnx@1f5f6582)**: Fix bug that kernel_shape rather than effective_kernel_shape is used in dilated conv (pytorch#2043) <daquexian>
- **[38b6c44e](onnx/onnx@38b6c44e)**: Changes done internally at Facebook (pytorch#2035) <Lu Fang>
- **[5c51f0db](onnx/onnx@5c51f0db)**: Explicitly specify type of integers in the input tensor. (pytorch#2034) <Dmitri Smirnov>

Reviewed By: benoitsteiner

Differential Revision: D15534241

fbshipit-source-id: 7f75707ea270e8fac0442431f7498ed47ba0cea2
jagadish-amd pushed a commit to jagadish-amd/pytorch that referenced this pull request May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants