Move at::NonVariableTypeMode to TensorImpl, and check it in is_variable() #20392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
the
module: internals
22 tasks
Contributor
Author
|
@pytorchbot retest this please |
li-roy
reviewed
May 11, 2019
| [static_cast<int>(Backend::NumOptions)]; | ||
| }; | ||
|
|
||
| CAFFE2_API LegacyTypeDispatch& globalLegacyTypeDispatch(); |
Contributor
There was a problem hiding this comment.
It won't let me put a comment there, but can you remove the at::NonVariableTypeMode::is_enabled() call from initializeLegacyTypeDispatchFor and legacyTensorType? Also expunge other call sites that are called in conjunction with is_variable()
gchanan
approved these changes
May 13, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
May 14, 2019
…le() (#20392) Summary: As part of the Variable/Tensor merge, we allow passing Tensor with AutogradMeta into ATen ops, but we want to make sure they are not treated as Variables (i.e. their `is_variable()` is false). This PR makes the necessary change to make this work. Pull Request resolved: pytorch/pytorch#20392 Differential Revision: D15321899 Pulled By: yf225 fbshipit-source-id: c2ab09db73c63bd71ba2d8391095f4d6b4240a9a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the Variable/Tensor merge, we allow passing Tensor with AutogradMeta into ATen ops, but we want to make sure they are not treated as Variables (i.e. their
is_variable()is false). This PR makes the necessary change to make this work.