[BC-breaking] Fix version counter sharing in set_data() #20391
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 10, 2019 23:30
pytorchbot
added
the
module: autograd
22 tasks
Contributor
Author
|
@pytorchbot retest this please |
gchanan
requested changes
May 13, 2019
| # In-place op on `x` also updates version of `xz`, | ||
| # because they share the version counter | ||
| x.add_(1) | ||
| self.assertTrue(x._version == xz._version) |
Contributor
There was a problem hiding this comment.
Some improvements to this test:
- change the variable through xz.
- check that changes post-set data actually increase the version counter.
yf225
force-pushed
the
set_data_version_counter
branch
from
2e8cfb3 to
f45dcaf
Compare
gchanan
approved these changes
May 13, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
yf225
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://github.com/pytorch/pytorch/pull/18223/files#diff-77a6f3462f2233b921d3042412fed6d3R178, we used
auto saved_version_ = data_.unsafeGetTensorImpl()->version_counter().current_version()and thennew_data_impl_copy->set_version_counter(saved_version_), which actually doesn't preserve the original semantics thatvar.set_data(tensor)should keepvar's version counter object intact. This PR fixes the bug and adds test to make sure it doesn't happen again.This PR is BC-breaking for v1.1.0, because v1.1.0 contains #18223 which introduces the bug. As an example, the following test passes on v1.0.1 and will pass on master after this PR is merged, but doesn't pass on v1.1.0: