[jit] Add save() to torch._C.Function
#20386
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
May 6, 2019 16:50
TensorList, DoubleList, and BoolList were missing from the pickler, so this adds them. As a follow up a lot of the code for these could be templated and cut down
added 2 commits
May 13, 2019 14:03
pytorchbot
added
the
module: pybind
driazati
changed the title
driazati
changed the title
save() to torch._C.Function
driazati
changed the title
save() to torch._C.Functionsave() to torch._C.Function
driazati
changed the title
save() to torch._C.Functionsave() to torch._C.Function
zdevito
approved these changes
May 18, 2019
Contributor
zdevito
left a comment
zdevito
left a comment
There was a problem hiding this comment.
Looks good, minor comments.
torch/csrc/jit/script/init.cpp
Outdated
| Module module; | ||
| // Make a graph with a fake self argument | ||
| auto graph = self->graph()->copy(); | ||
| graph->insertInput(0, "self"); |
Contributor
There was a problem hiding this comment.
The type of input 0 is not set here (it is also never checked, which is why it doesn't fail).
torch/csrc/jit/script/init.cpp
Outdated
| const ExtraFilesMap& _extra_files = ExtraFilesMap()) { | ||
| std::ostringstream buf; | ||
| Module module; | ||
| auto graph = self->graph()->copy(); |
Contributor
There was a problem hiding this comment.
Can we put the implementation in Function::save, and avoid duplicating the logic between save and save_to_buffer?
Contributor
Contributor
|
Does |
Contributor
Author
|
It does return a module for now, our serialization doesn't know about functions afaik and we wanted to at least get the save/load functionality back before fixing that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20017
This wraps the
torch._C.Functioncurrently returned fromtorch.jit.scriptandtorch.jit.tracein aScriptFunctionandTracedFunctionrespectively, both of which are just wrappers to hold the function.Differential Revision: D15403161