-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Functions: conv2d, sum_pool2d for LongTensor #20370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Differential Revision: D15192353 Differential Version: 81513072
|
Comment on CR for #20105: |
Differential Revision: D15192353 Differential Version: 81532976
|
About @gchanan comment on AvgPool for Long: I think it should be implemented. Bilinear / bicubic interpolation on integer types (uint8 for example) are widely used, and I don't think that AvgPool is that different from a bilinear downsampling. |
|
@fmassa do any of those have division on integer dtypes? From what I can tell, those only have division in backwards, and we don't support backwards on integer dtypes anyway. My naive interpretation would be AvgPool would actually return a non-integer dtype on integer dtype inputs, but we don't have (many) cross-dtype operations yet. Thoughts? |
|
@gchanan interpolate multiplies the values of the to be interpolated by a floating point value, so this is the same situation as in here. Note that our interpolate kernels do not support integer types yet, but I think they should. Interpolation for integer types is implemented in opencv and Pillow through, and I can grab some examples once I'm back to my computer |
|
But you do bring valid points though. Im not sure if we should stick with what is currently done in image processing libs, or adopt a more numpy-correct alternative |
Differential Revision: D15192353 Differential Version: 81880367
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ifedan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@pytorchbot retest this please |
Stack:
:black_circle: #20370 conv2d implmentation for LongTensor 💛
Differential Revision: D15192353