Skip to content

Fix bug in non_blocking copy #20305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
li-roy wants to merge 2 commits into from
Closed

Fix bug in non_blocking copy #20305

li-roy wants to merge 2 commits into from

Conversation

@li-roy
Copy link
Contributor

@li-roy li-roy commented May 9, 2019 •
edited
Loading

Stack from ghstack:

Differential Revision: D15276094

@pytorchbot pytorchbot added module: cuda Related to torch.cuda, and CUDA support in general module: operators labels May 9, 2019
@li-roy li-roy requested review from colesbury and ezyang May 9, 2019 18:30
@colesbury
Copy link
Member

colesbury commented May 9, 2019

I think you can test this with something like the following pseudo-code:

x = torch.empty(10, pinned_memory=True)
y = torch.randn(10, device='cuda')
torch.cuda._sleep(...)
event = torch.cuda.Event().record()
x.copy_(y, non_blocking=True)
# check that event hasn't occurred (i.e that the copy is really non-blocking)
# synchronize
# check that x and y are equal

@ezyang
Copy link
Contributor

ezyang commented May 10, 2019

Yes, a test would be great

Update on "Fix bug in non_blocking copy"
1cde7ea 
Fix bug in non_blocking copy

gh-metadata: pytorch pytorch 20305 gh/li-roy/12/head
@zou3519 zou3519 deleted the gh/li-roy/12/head branch May 11, 2019 22:22
zdevito pushed a commit to zdevito/ATen that referenced this pull request May 11, 2019
@facebook-github-bot
Fix bug in non_blocking copy (#20305)
55a7fac 
Summary:
Pull Request resolved: pytorch/pytorch#20305
ghimport-source-id: eb3dacb10fd93bbb5a6bbe078ed1ec842163d0e6

Differential Revision: D15276094

Pulled By: li-roy

fbshipit-source-id: 4728f419aa050e6c94a4f62231fa1a86caa556a7
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 11, 2019

@li-roy merged this pull request in 163f0e1.

@li-roy li-roy mentioned this pull request May 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes

@ezyang ezyang Awaiting requested review from ezyang

Assignees

No one assigned

Labels

Merged module: cuda Related to torch.cuda, and CUDA support in general

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@li-roy @colesbury @ezyang @facebook-github-bot @pytorchbot @mruberry