Only record grad_fn in C++ Scatter and Gather when required so #20286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
input data tensors regardless whether they require grad. This hits assertion failure in set_history(Tensor, shared_ptr<Function> grad_fn) where grad_fn cannot be nullptr. After this PR, C++ Scatter and Gather only record grad_fn when necessary.
pytorchbot
added
the
module: autograd
Contributor
Author
|
blocking #20238 |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mrshenli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
mrshenli
added
the
oncall: distributed
yf225
approved these changes
May 8, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mrshenli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
@pytorchbot retest this please |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++
ScatterandGatheralways set autograd history for input data tensors regardless whether they require grad. This hits assertion failure inset_history(Tensor, shared_ptr<Function> grad_fn)where
grad_fncannot be nullptr. After this PR, C++ScatterandGatheronly recordgrad_fnwhen required.