Skip to content

Conversation

@wanchaol
Copy link
Collaborator

@wanchaol wanchaol commented May 8, 2019

Stack from ghstack:

Summary:

tracing only record the c++ function we called (addmm/matmul), we should expose linear in tracing since we did the decomposition pass to decompose linear

@pytorchbot pytorchbot added the module: internals Related to internal abstractions in c10 and ATen label May 8, 2019
@wanchaol wanchaol changed the title make linear avaiable in tracing [jit] make linear avaiable in tracing May 8, 2019
make linear avaiable in tracing

gh-metadata: pytorch pytorch 20284 gh/wanchaol/5/head
wanchaol added 4 commits May 8, 2019 22:19
make linear avaiable in tracing

gh-metadata: pytorch pytorch 20284 gh/wanchaol/5/head
make linear avaiable in tracing

gh-metadata: pytorch pytorch 20284 gh/wanchaol/5/head
make linear avaiable in tracing

gh-metadata: pytorch pytorch 20284 gh/wanchaol/5/head
make linear avaiable in tracing

gh-metadata: pytorch pytorch 20284 gh/wanchaol/5/head
@wanchaol wanchaol requested review from bddppq, bwasti and houseroad May 9, 2019 18:22
make linear avaiable in tracing

gh-metadata: pytorch pytorch 20284 gh/wanchaol/5/head
@pytorchbot pytorchbot added module: onnx Related to torch.onnx module: tests Issues related to tests (not the torch.testing module) labels Jun 4, 2019
wanchaol added 2 commits June 4, 2019 12:02
make linear avaiable in tracing

gh-metadata: pytorch pytorch 20284 gh/wanchaol/5/head
make linear avaiable in tracing

gh-metadata: pytorch pytorch 20284 gh/wanchaol/5/head
@garymm
Copy link
Collaborator

garymm commented Sep 20, 2021

Closing as obsolete.
It seems like ONNX exporter now sees aten::linear, which makes me think it got implemented at some point?
See #54866

@garymm garymm closed this Sep 20, 2021
@facebook-github-bot facebook-github-bot deleted the gh/wanchaol/5/head branch October 21, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed module: internals Related to internal abstractions in c10 and ATen module: onnx Related to torch.onnx module: tests Issues related to tests (not the torch.testing module)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants