error instead of crashing on attempt to subclass typed tensors #20283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorch#20052 typed tensors (e.g. torch.FloatTensor) can't be subclassed. Was causing crashes and other errors.
pytorchbot
added
module: internals
gchanan
reviewed
May 8, 2019
|
|
||
| def test_subclass_tensors(self): | ||
| # raise an error when trying to subclass FloatTensor | ||
| with self.assertRaisesRegex(TypeError, "type 'torch.FloatTensor' is not an acceptable base type"): |
Contributor
There was a problem hiding this comment.
I'm curious if this error message is actually stable -- I guess the CI will tell us.
gchanan
reviewed
May 8, 2019
| def foo(self): | ||
| return 5 | ||
| f = Foo() | ||
| self.assertEqual(f.foo(), 5) |
Contributor
There was a problem hiding this comment.
I'd prefer doing something with the Tensor, e.g. you could just check it's shape is () here.
gchanan
approved these changes
May 8, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@nairbv is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#20052
typed tensors (e.g. torch.FloatTensor) can't be subclassed. Was causing
crashes and other errors.