[jit] Convenience APIs for script objects #20226
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compiler should be emitting static lookups to object slots, but people using the C++ API should have some sugar for doing attribute lookup.
pytorchbot
added
oncall: jit
[jit] Convenience APIs for script objects The compiler should be emitting static lookups to object slots, but people using the C++ API should have some sugar for doing attribute lookup. gh-metadata: pytorch pytorch 20226 gh/suo/36/head
zdevito
approved these changes
May 8, 2019
| return this->type_->qualname(); | ||
| } | ||
|
|
||
| IValue ivalue::Object::getAttr(const std::string& name) const { |
Contributor
There was a problem hiding this comment.
Probably want the same api as pybind11, which uses attr
Member
Author
There was a problem hiding this comment.
pybind's attr returns a functor which lets you write to the object by assigning to it. I think that's probably a little overkill in this case.
I think i'll expose static getattr and setattr like the python builtins
Contributor
There was a problem hiding this comment.
The old API seems simpler, this makes it more like a C API. Maybe we shouldn't try to match pythons semantics here?
Member
Author
There was a problem hiding this comment.
I'm okay with that. whatever is more natural for people I guess
test/cpp/jit/test_class_import.h
Outdated
| constantTable, | ||
| nullptr); | ||
|
|
||
| // Incorrect arguments for constructor should throow |
[jit] Convenience APIs for script objects The compiler should be emitting static lookups to object slots, but people using the C++ API should have some sugar for doing attribute lookup. gh-metadata: pytorch pytorch 20226 gh/suo/36/head
[jit] Convenience APIs for script objects The compiler should be emitting static lookups to object slots, but people using the C++ API should have some sugar for doing attribute lookup. gh-metadata: pytorch pytorch 20226 gh/suo/36/head
[jit] Convenience APIs for script objects The compiler should be emitting static lookups to object slots, but people using the C++ API should have some sugar for doing attribute lookup. gh-metadata: pytorch pytorch 20226 gh/suo/36/head
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
May 10, 2019
Summary: Pull Request resolved: pytorch/pytorch#20226 ghimport-source-id: 22937d72e35ec4eba38019284a368453089fe3eb Differential Revision: D15243625 Pulled By: suo fbshipit-source-id: 5e9fb773da244f9ef201dba524155c3b19b2b4e0
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
The compiler should be emitting static lookups to object slots, but
people using the C++ API should have some sugar for doing attribute
lookup.
Differential Revision: D15243625