add str builtin support #20188
Closed
add str builtin support #20188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: adds str builtin cast to turn values into strings Test Plan: python test/test_jit.py
pytorchbot
added
oncall: jit
suo
approved these changes
May 6, 2019
add str builtin support Summary: adds str builtin cast to turn values into strings Test Plan: python test/test_jit.py gh-metadata: pytorch pytorch 20188 gh/zdevito/36/head
Contributor
zdevito
added a commit
to zdevito/ATen
that referenced
this pull request
May 8, 2019
Summary: Pull Request resolved: pytorch/pytorch#20188 ghimport-source-id: 390b889f67155eb6168a96d05307ec4e86f5c631 Differential Revision: D15228812 Pulled By: zdevito fbshipit-source-id: 789efa2e0b2f9518ed97ac877b59637e5b0ebcf4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary: adds str builtin cast to turn values into strings
Test Plan: python test/test_jit.py
Differential Revision: D15228812