[jit] fix compilation order for class methods #20094
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that methods are reported in Python in name order instead of definition order. This means that potentially we can try to compile a method before __init__, which will break if we wanted to use any attributes that get defined in __init__. This PR fixes that by special-casing __init__ so that its always compiled first. Fixes #20004.
[jit] fix compilation order for class methods It turns out that methods are reported in Python in name order instead of definition order. This means that potentially we can try to compile a method before __init__, which will break if we wanted to use any attributes that get defined in __init__. This PR fixes that by special-casing __init__ so that its always compiled first. Fixes #20004. gh-metadata: pytorch pytorch 20094 gh/suo/34/head
Contributor
|
Does this mean that calling methods from within |
Member
Author
No, that's fine, we lazily compile class methods (see |
[jit] fix compilation order for class methods It turns out that methods are reported in Python in name order instead of definition order. This means that potentially we can try to compile a method before __init__, which will break if we wanted to use any attributes that get defined in __init__. This PR fixes that by special-casing __init__ so that its always compiled first. Fixes #20004. gh-metadata: pytorch pytorch 20094 gh/suo/34/head
zdevito
approved these changes
May 6, 2019
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
It turns out that methods are reported in Python in name order instead
of definition order. This means that potentially we can try to compile a
method before init, which will break if we wanted to use any
attributes that get defined in init.
This PR fixes that by special-casing init so that its always
compiled first. Fixes #20004.
Differential Revision: D15197079