Index into a tuple with non constant integer #20081
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@pytorchbot retest this please |
Contributor
Author
|
@pytorchbot rebase this please |
driazati
reviewed
May 2, 2019
| /*allow_conversions*/ true); | ||
| if (list == tuple_val) { | ||
| throw ErrorReport(loc) | ||
| << "Cannot index into a " << tuple_typ->python_str() |
Contributor
There was a problem hiding this comment.
This could be more clear, maybe something like ... non-constant index because it has multiple element types
Contributor
Author
There was a problem hiding this comment.
Agreed that would be a little more clear, but then it wouldn't handle the zero-tuple case, and i think it's still clear as is
driazati
reviewed
May 3, 2019
driazati
approved these changes
May 3, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@eellison is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #16962
This needs fixing because we turn lists into tuples when constantify a module, so indexing into a Tuple of one type with a non-constant integer is quite common.