Port ATen/native to ATen/Parallel #20043
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Remove explicit usage of OpenMP from ATen/native Test Plan: BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch
pytorchbot
added
module: cpu
This was referenced May 2, 2019
ilia-cher
requested review from
VitalyFedyunin,
cpuhrsch,
dzhulgakov,
jamesr66a,
soumith and
suo
Port ATen/native to ATen/Parallel Summary: Remove explicit usage of OpenMP from ATen/native Test Plan: BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch gh-metadata: pytorch pytorch 20043 gh/ilia-cher/12/head
This was referenced May 2, 2019
Port ATen/native to ATen/Parallel Summary: Remove explicit usage of OpenMP from ATen/native Test Plan: BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch gh-metadata: pytorch pytorch 20043 gh/ilia-cher/12/head
Contributor
Author
|
bugfix + double checked all other call sites |
ilia-cher
commented
May 2, 2019
|
|
||
| #ifdef _OPENMP | ||
| auto parallel_section = [&](int64_t start, int64_t end) { | ||
| for (int64_t i = 0; i < numel; i++) { |
Contributor
Author
There was a problem hiding this comment.
btw, note that here this is correct, we parallelize inside the loop
dzhulgakov
approved these changes
May 3, 2019
Collaborator
dzhulgakov
left a comment
dzhulgakov
left a comment
There was a problem hiding this comment.
ok, I'll trust your audit :)
added 3 commits
May 6, 2019 13:18
Port ATen/native to ATen/Parallel Summary: Remove explicit usage of OpenMP from ATen/native Test Plan: BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch gh-metadata: pytorch pytorch 20043 gh/ilia-cher/12/head
Port ATen/native to ATen/Parallel Summary: Remove explicit usage of OpenMP from ATen/native Test Plan: BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch gh-metadata: pytorch pytorch 20043 gh/ilia-cher/12/head
Port ATen/native to ATen/Parallel Summary: Remove explicit usage of OpenMP from ATen/native Test Plan: BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch gh-metadata: pytorch pytorch 20043 gh/ilia-cher/12/head
added 8 commits
May 6, 2019 16:53
Port ATen/native to ATen/Parallel Summary: Remove explicit usage of OpenMP from ATen/native Test Plan: BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch gh-metadata: pytorch pytorch 20043 gh/ilia-cher/12/head
Port ATen/native to ATen/Parallel Summary: Remove explicit usage of OpenMP from ATen/native Test Plan: BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch gh-metadata: pytorch pytorch 20043 gh/ilia-cher/12/head
Port ATen/native to ATen/Parallel Summary: Remove explicit usage of OpenMP from ATen/native Test Plan: BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch gh-metadata: pytorch pytorch 20043 gh/ilia-cher/12/head
Port ATen/native to ATen/Parallel Summary: Remove explicit usage of OpenMP from ATen/native Test Plan: BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch gh-metadata: pytorch pytorch 20043 gh/ilia-cher/12/head
Port ATen/native to ATen/Parallel Summary: Remove explicit usage of OpenMP from ATen/native Test Plan: BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch gh-metadata: pytorch pytorch 20043 gh/ilia-cher/12/head
Port ATen/native to ATen/Parallel Summary: Remove explicit usage of OpenMP from ATen/native Test Plan: BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch gh-metadata: pytorch pytorch 20043 gh/ilia-cher/12/head
Port ATen/native to ATen/Parallel Summary: Remove explicit usage of OpenMP from ATen/native Test Plan: BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch gh-metadata: pytorch pytorch 20043 gh/ilia-cher/12/head
Port ATen/native to ATen/Parallel Summary: Remove explicit usage of OpenMP from ATen/native Test Plan: BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake pytest -s -v test/test_torch.py::TestTorch gh-metadata: pytorch pytorch 20043 gh/ilia-cher/12/head
Contributor
|
@ilia-cher merged this pull request in 2a104f7. |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
May 8, 2019
Summary: Pull Request resolved: pytorch/pytorch#20043 ghimport-source-id: 8003ef8ca335d4c4717a886a3a75fd78ec53ade5 Differential Revision: D15248505 Pulled By: ilia-cher fbshipit-source-id: 7be500ed8bfb23cc36f1dd7108e344319e3e5332
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Remove explicit usage of OpenMP from ATen/native
Test Plan:
BLAS=MKL USE_MKLDNN=1 USE_OPENCV=1 USE_FFMPEG=1 python setup.py develop --cmake
pytest -s -v test/test_torch.py::TestTorch
Differential Revision: D15248505