Rotate circleci keys #19981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

pjh5 wants to merge 1 commit into pytorch:master from pjh5:rotate

Contributor

pjh5 commented Apr 30, 2019

No description provided.

pytorchbot added the module: ci label

pjh5 force-pushed the rotate branch from b4ee590 to f535615 Compare

April 30, 2019 22:40

yf225 reviewed

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

yf225 reviewed

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

yf225 reviewed

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

yf225 reviewed

View reviewed changes

.circleci/config.yml Outdated Show resolved Hide resolved

yf225 reviewed

View reviewed changes

.circleci/verbatim-sources/job-specs-custom.yml Outdated Show resolved Hide resolved

yf225 reviewed

View reviewed changes

.circleci/verbatim-sources/job-specs-custom.yml Outdated Show resolved Hide resolved

yf225 reviewed

View reviewed changes

.circleci/verbatim-sources/macos-build-defaults.yml Outdated Show resolved Hide resolved

yf225 reviewed

View reviewed changes

.circleci/verbatim-sources/job-specs-custom.yml Outdated Show resolved Hide resolved

yf225 requested changes

View reviewed changes

Contributor

yf225 left a comment

Did we wrap all places where we do AWS_ACCESS_KEY_ID= with set +x/set -x? It seems some of them are missing, e.g.

pytorch/.circleci/config.yml

Lines 1213 to 1214 in ba84ad0

    
                       export AWS_ACCESS_KEY_ID=${CIRCLECI_AWS_ACCESS_KEY_FOR_SCCACHE_S3_BUCKET_V3} 
        
                       export AWS_SECRET_ACCESS_KEY=${CIRCLECI_AWS_SECRET_KEY_FOR_SCCACHE_S3_BUCKET_V3}

.


          Rotate circleci keys and add a little more security

b382347

pjh5 force-pushed the rotate branch from f535615 to b382347 Compare

May 1, 2019 20:16

yf225 approved these changes

View reviewed changes

facebook-github-bot reviewed

View reviewed changes

Contributor

facebook-github-bot left a comment

@pjh5 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot closed this in

0da0c4b

facebook-github-bot added the merged label

Contributor

facebook-github-bot commented May 1, 2019

@pjh5 merged this pull request in 0da0c4b.

pjh5 deleted the rotate branch

May 2, 2019 00:06

zhangguanheng66 pushed a commit to zhangguanheng66/pytorch that referenced this pull request


          Rotate circleci keys

e9442b0

Summary: Pull Request resolved: pytorch#19981

Differential Revision: D15174219

Pulled By: pjh5

fbshipit-source-id: 205952aa90ed93f193f40d4293f5a8d82fa33ed6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels