Conv double backward groups #1993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Ok, so my worry is confirmed as the cont built timeout :'( |
Contributor
|
hmmm, they ran for 10 minutes? that's weird. Maybe heavier tests are enabled by default, but can be disabled with an env flag (we can keep them enabled for the GPU builds, but not the travis builds?) |
Collaborator
Author
|
I will do some testing locally and try and reduce the number of tests while covering all use cases. |
Collaborator
Author
|
@soumith I reduced unnecessary tests such as testing many possible possible output channel or all even and uneven kernel/input sizes. |
soumith
approved these changes
Jul 13, 2017
Contributor
|
awesome, thanks Alban! |
zou3519
pushed a commit
to zou3519/pytorch
that referenced
this pull request
Mar 30, 2018
* wip: cuda targets * Remove FindCuDNN.cmake as it is no longer needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1972
@apaszke I am starting to worry that the conv double backward test are taking too much time because they test all possible combination of parameters.
If you think this is a problem, maybe I could leave a subset of these tests (most common cases only) in
test_nn.pyand move the complete tests to a separate file? I am not sure if it's a good solution though.