[jit] Try to script all Python functions #19747
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
oncall: jit
facebook-github-bot
pushed a commit
that referenced
this pull request
May 30, 2019
Summary: Following on #19747, this implements most of the `torch.jit.script()` changes laid out in #20939. Still to do: * Accessing a method from Python does not add it as a `ScriptMethod` (so only `export`ed methods and `forward` are compiled) * Calling a method other than `forward` on a submodule doesn't work ](https://our.intern.facebook.com/intern/diff/15546045/) Pull Request resolved: #20708 Pulled By: driazati Differential Revision: D15546045 fbshipit-source-id: c2c8fe179088ffbdad47198e799a456560655b86
facebook-github-bot
pushed a commit
that referenced
this pull request
May 31, 2019
Summary: Following on #19747, this implements most of the `torch.jit.script()` changes laid out in #20939. Still to do: * Accessing a method from Python does not add it as a `ScriptMethod` (so only `export`ed methods and `forward` are compiled) * Calling a method other than `forward` on a submodule doesn't work ](https://our.intern.facebook.com/intern/diff/15560490/) Pull Request resolved: #20708 Pulled By: driazati Differential Revision: D15560490 fbshipit-source-id: cc7ef3a1c2772eff9beba5f3e66546d2b7d7198a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack: