Remove unnecessary printing from tests #19606
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorchbot
added
module: operators
module: tests
ssnl
commented
Apr 23, 2019
test/test_torch.py
Outdated
Collaborator
Author
There was a problem hiding this comment.
cc @jerryzh168
I don't know what these comments were for. Let me know if you think this TODO is inaccurate and I will update accordingly.
ssnl
commented
Apr 23, 2019
test/test_utils.py
Outdated
Collaborator
Author
There was a problem hiding this comment.
This prints more than 40% of the CI log:
torchvision issue: pytorch/vision#862
Collaborator
Author
|
Test failure is unrelated |
ezyang
approved these changes
Apr 23, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
zhangguanheng66
pushed a commit
to zhangguanheng66/pytorch
that referenced
this pull request
May 6, 2019
Summary: Pull Request resolved: pytorch#19606 Differential Revision: D15046583 Pulled By: ezyang fbshipit-source-id: ea9bb691d23855e7eddbabe68bf112a726641ba4
This was referenced Jun 20, 2019
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 22, 2019
Summary: #21132 reverted #19606. Now these tests again print like 40% lines of CI outputs (e.g., https://circleci.com/gh/pytorch/pytorch/2041825?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link) This PR now uses the functionality introduced in pytorch/vision#862. Pull Request resolved: #22043 Differential Revision: D15947268 Pulled By: ailzhang fbshipit-source-id: f84f4d6b86203dbe8687e04ae3ed8c99df0bdff8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.